qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] block: Remove unused callback function *bdrv_aio_pdiscard


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2] block: Remove unused callback function *bdrv_aio_pdiscard
Date: Tue, 22 Apr 2025 09:09:28 +0200
User-agent: Mozilla Thunderbird

On 21/4/25 20:21, Sunny Zhu wrote:
The bytes type in *bdrv_aio_pdiscard should be int64_t rather than int.

There are no drivers implementing the *bdrv_aio_pdiscard() callback,
it appears to be an unused function. Therefore, we'll simply remove it
instead of fixing it.

Additionally, coroutine-based callbacks are preferred. If someone needs
to implement bdrv_aio_pdiscard, a coroutine-based version would be
straightforward to implement.

Signed-off-by: Sunny Zhu <sunnyzhyy@qq.com>
---
  block/io.c                       | 22 +++-------------------
  include/block/block_int-common.h |  4 ----
  2 files changed, 3 insertions(+), 23 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]