qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 06/20] contrib/plugins: Fix type conflict of GLib function


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 06/20] contrib/plugins: Fix type conflict of GLib function pointers
Date: Tue, 22 Apr 2025 08:40:55 +0200
User-agent: Mozilla Thunderbird

On 22/4/25 07:27, Kohei Tokunaga wrote:
On Emscripten, function pointer casts can result in runtime failures due to
strict function signature checks. This affects the use of g_list_sort and
g_slist_sort, which internally perform function pointer casts that are not
supported by Emscripten. To avoid these issues, g_list_sort_with_data and
g_slist_sort_with_data should be used instead, as they do not rely on
function pointer casting.

Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
---
  contrib/plugins/cache.c     | 12 ++++++------
  contrib/plugins/cflow.c     | 10 +++++-----
  contrib/plugins/hotblocks.c |  4 ++--
  contrib/plugins/hotpages.c  |  4 ++--
  contrib/plugins/howvec.c    |  4 ++--
  contrib/plugins/hwprofile.c |  8 ++++----
  tests/tcg/plugins/mem.c     |  4 ++--
  tests/tcg/plugins/syscall.c |  4 ++--
  8 files changed, 25 insertions(+), 25 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]