[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] i386/xen: Move KVM_XEN_HVM_CONFIG ioctl to kvm_xen_init_
|
From: |
Sean Christopherson |
|
Subject: |
Re: [PATCH 1/2] i386/xen: Move KVM_XEN_HVM_CONFIG ioctl to kvm_xen_init_vcpu() |
|
Date: |
Fri, 7 Feb 2025 07:37:40 -0800 |
On Fri, Feb 07, 2025, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> At the time kvm_xen_init() is called, hyperv_enabled() doesn't yet work, so
> the correct MSR index to use for the hypercall page isn't known.
>
> Rather than setting it to the default and then shifting it later for the
> Hyper-V case with a confusing second call to kvm_init_xen(), just do it
> once in kvm_xen_init_vcpu().
Is it possible the funky double-init is deliberate, to ensure that Xen is
configured in KVM during VM setup? I looked through KVM and didn't see any
obvious dependencies, but that doesn't mean a whole lot.