Re: [PATCH] vmdk: Don't corrupt desc file in vmdk_write_cid

[Kevin Wolf]

Am 24.11.2023 um 12:56 hat Fam geschrieben:
> From: Fam Zheng <fam@euphon.net>
> 
> If the text description file is larger than DESC_SIZE, we force the last
> byte in the buffer to be 0 and write it out.
> 
> This results in a corruption.
> 
> Try to allocate a big buffer in this case.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1923
> 
> Signed-off-by: Fam Zheng <fam@euphon.net>

Thanks, applied to the block branch.

But while I'm looking at this function, is there really anything that
guarantees that "parentCID" always exists and comes immediately after
"CID"? This looks like a questionable assumption to me.

Kevin