Re: [PATCH 04/16] qemu-file: Don't call qemu

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 04/16] qemu-file: Don't call qemu_fflush() for read only file

From:	Richard Henderson
Subject:	Re: [PATCH 04/16] qemu-file: Don't call qemu_fflush() for read only files
Date:	Tue, 30 May 2023 10:01:43 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

On 5/30/23 05:28, Juan Quintela wrote:

This was the only caller for read only files.  So change the test for
an assert in qemu_fflush().



Not a fan, as fflush(stdin) is well-defined.


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 06/16] qemu_file: Use a stat64 for qemu_file_transferred, (continued)
- [PATCH 06/16] qemu_file: Use a stat64 for qemu_file_transferred, Juan Quintela, 2023/05/30
- [PATCH 03/16] migration: Use qemu_file_transferred_noflush() for block migration., Juan Quintela, 2023/05/30
  - Re: [PATCH 03/16] migration: Use qemu_file_transferred_noflush() for block migration., Fabiano Rosas, 2023/05/30
- [PATCH 13/16] qemu-file: Simplify qemu_file_get_error(), Juan Quintela, 2023/05/30
  - Re: [PATCH 13/16] qemu-file: Simplify qemu_file_get_error(), Fabiano Rosas, 2023/05/30
- [PATCH 05/16] qemu-file: We only call qemu_file_transferred_* on the sending side, Juan Quintela, 2023/05/30
- [PATCH 08/16] migration: Use the number of transferred bytes directly, Juan Quintela, 2023/05/30
- [PATCH 09/16] qemu_file: Remove unused qemu_file_transferred(), Juan Quintela, 2023/05/30
- [PATCH 04/16] qemu-file: Don't call qemu_fflush() for read only files, Juan Quintela, 2023/05/30
  - Re: [PATCH 04/16] qemu-file: Don't call qemu_fflush() for read only files, Fabiano Rosas, 2023/05/30
  - Re: [PATCH 04/16] qemu-file: Don't call qemu_fflush() for read only files, Richard Henderson <=
    - Re: [PATCH 04/16] qemu-file: Don't call qemu_fflush() for read only files, Juan Quintela, 2023/05/30
    - Re: [PATCH 04/16] qemu-file: Don't call qemu_fflush() for read only files, Richard Henderson, 2023/05/30
    - Re: [PATCH 04/16] qemu-file: Don't call qemu_fflush() for read only files, Juan Quintela, 2023/05/30
  - Re: [PATCH 04/16] qemu-file: Don't call qemu_fflush() for read only files, Juan Quintela, 2023/05/30
- [PATCH 10/16] qemu-file: Remove _noflush from qemu_file_transferred_noflush(), Juan Quintela, 2023/05/30
  - Re: [PATCH 10/16] qemu-file: Remove _noflush from qemu_file_transferred_noflush(), Fabiano Rosas, 2023/05/30
    - Re: [PATCH 10/16] qemu-file: Remove _noflush from qemu_file_transferred_noflush(), Juan Quintela, 2023/05/30
- [PATCH 01/16] qemu-file: Rename qemu_file_transferred_ fast -> noflush, Juan Quintela, 2023/05/30
  - Re: [PATCH 01/16] qemu-file: Rename qemu_file_transferred_ fast -> noflush, Philippe Mathieu-Daudé, 2023/05/30
    - Re: [PATCH 01/16] qemu-file: Rename qemu_file_transferred_ fast -> noflush, Philippe Mathieu-Daudé, 2023/05/30

Prev by Date: [PULL 32/32] aio: remove aio_disable_external() API
Next by Date: Re: [PATCH 04/16] qemu-file: Don't call qemu_fflush() for read only files
Previous by thread: Re: [PATCH 04/16] qemu-file: Don't call qemu_fflush() for read only files
Next by thread: Re: [PATCH 04/16] qemu-file: Don't call qemu_fflush() for read only files
Index(es):
- Date
- Thread