Re: [PATCH v3 04/14] nbd: Prepare for 64-bit request effect lengths

[Vladimir Sementsov-Ogievskiy]

On 15.05.23 22:53, Eric Blake wrote:
> Widen the length field of NBDRequest to 64-bits, although we can
> assert that all current uses are still under 32 bits.  Move the
> request magic number to nbd.h, to live alongside the reply magic
> number.  Convert 'bool structured_reply' into a tri-state enum that
> will eventually track whether the client successfully negotiated
> extended headers with the server, allowing the nbd driver to pass
> larger requests along where possible; although in this patch the enum
> never surpasses structured replies, for no semantic change yet.
>
> Signed-off-by: Eric Blake<eblake@redhat.com>

Seems too much for one patch, could it could be split into
- Convert 'bool structured_reply'
- introduce third parameter for nbd_send_request()
- rework len to 64bit

otherwise, looks good to me

--
Best regards,
Vladimir