[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/12] block: Clarify locking rules for bdrv_open(_inherit)()
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH 02/12] block: Clarify locking rules for bdrv_open(_inherit)() |
|
Date: |
Thu, 25 May 2023 14:16:23 -0400 |
On Thu, May 25, 2023 at 02:47:03PM +0200, Kevin Wolf wrote:
> These functions specify that the caller must hold the "@filename
> AioContext lock". This doesn't make sense, file names don't have an
> AioContext. New BlockDriverStates always start in the main AioContext,
> so this is what we really need here.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature
- Re: [PATCH 05/12] mirror: Hold main AioContext lock for calling bdrv_open_backing_file(), (continued)
- [PATCH 07/12] raw-format: Fix open with 'file' in iothread, Kevin Wolf, 2023/05/25
- [PATCH 12/12] iotests: Test blockdev-create in iothread, Kevin Wolf, 2023/05/25
- [PATCH 08/12] copy-before-write: Fix open with child in iothread, Kevin Wolf, 2023/05/25
- [PATCH 04/12] block-backend: Fix blk_new_open() for iothreads, Kevin Wolf, 2023/05/25
- [PATCH 02/12] block: Clarify locking rules for bdrv_open(_inherit)(), Kevin Wolf, 2023/05/25
- Re: [PATCH 02/12] block: Clarify locking rules for bdrv_open(_inherit)(),
Stefan Hajnoczi <=
- [PATCH 09/12] block: Take AioContext lock in bdrv_open_driver(), Kevin Wolf, 2023/05/25
- [PATCH 06/12] qcow2: Fix open with 'file' in iothread, Kevin Wolf, 2023/05/25
- [PATCH 10/12] block: Fix AioContext locking in bdrv_insert_node(), Kevin Wolf, 2023/05/25
- [PATCH 11/12] iotests: Make verify_virtio_scsi_pci_or_ccw() public, Kevin Wolf, 2023/05/25