[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 07/10] hw/virtio/vhost-vsock: Include missing 'virtio/virt
From: |
Alex Bennée |
Subject: |
Re: [PATCH v2 07/10] hw/virtio/vhost-vsock: Include missing 'virtio/virtio-bus.h' header |
Date: |
Wed, 24 May 2023 16:04:06 +0100 |
User-agent: |
mu4e 1.11.6; emacs 29.0.91 |
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> Instead of having "virtio/virtio-bus.h" implicitly included,
> explicitly include it, to avoid when rearranging headers:
>
> hw/virtio/vhost-vsock-common.c: In function ‘vhost_vsock_common_start’:
> hw/virtio/vhost-vsock-common.c:51:5: error: unknown type name
> ‘VirtioBusClass’; did you mean ‘VirtioDeviceClass’?
> 51 | VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
> | ^~~~~~~~~~~~~~
> | VirtioDeviceClass
> hw/virtio/vhost-vsock-common.c:51:25: error: implicit declaration of
> function ‘VIRTIO_BUS_GET_CLASS’; did you mean ‘VIRTIO_DEVICE_CLASS’?
> [-Werror=implicit-function-declaration]
> 51 | VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
> | ^~~~~~~~~~~~~~~~~~~~
> | VIRTIO_DEVICE_CLASS
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> hw/virtio/vhost-vsock-common.c | 1 +
> 1 file changed, 1 insertion(+)
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
- Re: [PATCH v2 03/10] hw/scsi: Rearrange meson.build, (continued)
- [PATCH v2 04/10] hw/scsi: Rename target-specific source set as 'specific_virtio_scsi_ss', Philippe Mathieu-Daudé, 2023/05/24
- [PATCH v2 05/10] hw/virtio: Introduce VHOST_VSOCK_COMMON symbol in Kconfig, Philippe Mathieu-Daudé, 2023/05/24
- [PATCH v2 06/10] hw/virtio/virtio-mem: Use qemu_ram_get_fd() helper, Philippe Mathieu-Daudé, 2023/05/24
- [PATCH v2 07/10] hw/virtio/vhost-vsock: Include missing 'virtio/virtio-bus.h' header, Philippe Mathieu-Daudé, 2023/05/24
- [PATCH v2 08/10] hw/virtio/virtio-iommu: Use target-agnostic qemu_target_page_mask(), Philippe Mathieu-Daudé, 2023/05/24
- [PATCH v2 09/10] hw/virtio: Remove unnecessary 'virtio-access.h' header, Philippe Mathieu-Daudé, 2023/05/24
- [PATCH v2 10/10] hw/virtio: Build various target-agnostic objects just once, Philippe Mathieu-Daudé, 2023/05/24
- Re: [PATCH v2 00/10] hw/virtio: Build various target-agnostic objects just once, Philippe Mathieu-Daudé, 2023/05/31