Re: [RFC PATCH 1/6] block: Remove bdrv_query_block_node_info

[Claudio Fontana]

On 5/23/23 23:38, Fabiano Rosas wrote:
> The last call site of this function has been removed by commit
> c04d0ab026 ("qemu-img: Let info print block graph").
> 
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>  block/qapi.c         | 27 ---------------------------
>  include/block/qapi.h |  3 ---
>  2 files changed, 30 deletions(-)
> 
> diff --git a/block/qapi.c b/block/qapi.c
> index f34f95e0ef..79bf80c503 100644
> --- a/block/qapi.c
> +++ b/block/qapi.c
> @@ -309,33 +309,6 @@ out:
>      aio_context_release(bdrv_get_aio_context(bs));
>  }
>  
> -/**
> - * bdrv_query_block_node_info:
> - * @bs: block node to examine
> - * @p_info: location to store node information
> - * @errp: location to store error information
> - *
> - * Store image information about @bs in @p_info.
> - *
> - * @p_info will be set only on success. On error, store error in @errp.
> - */
> -void bdrv_query_block_node_info(BlockDriverState *bs,
> -                                BlockNodeInfo **p_info,
> -                                Error **errp)
> -{
> -    BlockNodeInfo *info;
> -    ERRP_GUARD();
> -
> -    info = g_new0(BlockNodeInfo, 1);
> -    bdrv_do_query_node_info(bs, info, errp);
> -    if (*errp) {
> -        qapi_free_BlockNodeInfo(info);
> -        return;
> -    }
> -
> -    *p_info = info;
> -}
> -
>  /**
>   * bdrv_query_image_info:
>   * @bs: block node to examine
> diff --git a/include/block/qapi.h b/include/block/qapi.h
> index 18d48ddb70..8663971c58 100644
> --- a/include/block/qapi.h
> +++ b/include/block/qapi.h
> @@ -36,9 +36,6 @@ BlockDeviceInfo *bdrv_block_device_info(BlockBackend *blk,
>  int bdrv_query_snapshot_info_list(BlockDriverState *bs,
>                                    SnapshotInfoList **p_list,
>                                    Error **errp);
> -void bdrv_query_block_node_info(BlockDriverState *bs,
> -                                BlockNodeInfo **p_info,
> -                                Error **errp);
>  void bdrv_query_image_info(BlockDriverState *bs,
>                             ImageInfo **p_info,
>                             bool flat,

Reviewed-by: Claudio Fontana <cfontana@suse.de>