Re: [PULL 18/18] tested: add test for nested aio_poll() in poll handlers

[Kevin Wolf]

Am 17.05.2023 um 21:10 hat Richard Henderson geschrieben:
> On 5/17/23 09:51, Kevin Wolf wrote:
> > From: Stefan Hajnoczi <stefanha@redhat.com>
> > 
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > Message-Id: <20230502184134.534703-3-stefanha@redhat.com>
> > Tested-by: Kevin Wolf <kwolf@redhat.com>
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> >   tests/unit/test-nested-aio-poll.c | 130 ++++++++++++++++++++++++++++++
> >   tests/unit/meson.build            |   1 +
> >   2 files changed, 131 insertions(+)
> >   create mode 100644 tests/unit/test-nested-aio-poll.c
> 
> This new test fails on windows:
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/4304413315#L3375
> https://gitlab.com/qemu-project/qemu/-/jobs/4304413313#L3357

What the CI output doesn't show is that the problem seems to be that the
test doesn't even make sense on Windows. When I run it manually:

Unexpected error in aio_context_set_poll_params() at 
../../home/kwolf/source/qemu/util/aio-win32.c:443:
Z:\tmp\build-win32\tests\unit\test-nested-aio-poll.exe: AioContext polling is 
not implemented on Windows

Stefan, I'll squash in the following, so you don't have to resubmit the
series.

Kevin


diff --git a/tests/unit/meson.build b/tests/unit/meson.build
index a314f82baa..8ed81786ee 100644
--- a/tests/unit/meson.build
+++ b/tests/unit/meson.build
@@ -67,7 +67,6 @@ if have_block
     'test-coroutine': [testblock],
     'test-aio': [testblock],
     'test-aio-multithread': [testblock],
-    'test-nested-aio-poll': [testblock],
     'test-throttle': [testblock],
     'test-thread-pool': [testblock],
     'test-hbitmap': [testblock],
@@ -115,7 +114,10 @@ if have_block
     tests += {'test-crypto-xts': [crypto, io]}
   endif
   if 'CONFIG_POSIX' in config_host
-    tests += {'test-image-locking': [testblock]}
+    tests += {
+      'test-image-locking': [testblock],
+      'test-nested-aio-poll': [testblock],
+    }
   endif
   if config_host_data.get('CONFIG_REPLICATION')
     tests += {'test-replication': [testblock]}