[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/8] qemu-img: Take graph lock more selectively
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 4/8] qemu-img: Take graph lock more selectively |
|
Date: |
Fri, 12 May 2023 11:20:14 -0500 |
|
User-agent: |
NeoMutt/20230512 |
On Wed, May 10, 2023 at 10:35:57PM +0200, Kevin Wolf wrote:
>
> If we take a reader lock, we can't call any functions that take a writer
> lock internally without causing deadlocks once the reader lock is
> actually enforced in the main thread, too. Take the reader lock only
> where it is actually needed.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> qemu-img.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- Re: [PATCH 1/8] block: Call .bdrv_co_create(_opts) unlocked, (continued)
[PATCH 2/8] block/export: Fix null pointer dereference in error path, Kevin Wolf, 2023/05/10
[PATCH 3/8] qcow2: Unlock the graph in qcow2_do_open() where necessary, Kevin Wolf, 2023/05/10
[PATCH 4/8] qemu-img: Take graph lock more selectively, Kevin Wolf, 2023/05/10
- Re: [PATCH 4/8] qemu-img: Take graph lock more selectively,
Eric Blake <=
[PATCH 6/8] test-bdrv-drain: Call bdrv_co_unref() in coroutine context, Kevin Wolf, 2023/05/10
[PATCH 5/8] test-bdrv-drain: Take graph lock more selectively, Kevin Wolf, 2023/05/10
[PATCH 7/8] blockjob: Adhere to rate limit even when reentered early, Kevin Wolf, 2023/05/10
[PATCH 8/8] graph-lock: Honour read locks even in the main thread, Kevin Wolf, 2023/05/10