Re: [PATCH v8 2/5] blockdev: transactions: rename some things

[Kevin Wolf]

Am 21.04.2023 um 13:53 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Look at qmp_transaction(): dev_list is not obvious name for list of
> actions. Let's look at qapi spec, this argument is "actions". Let's
> follow the common practice of using same argument names in qapi scheme
> and code.
> 
> To be honest, rename props to properties for same reason.
> 
> Next, we have to rename global map of actions, to not conflict with new
> name for function argument.
> 
> Rename also dev_entry loop variable accordingly to new name of the
> list.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>