[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] iotests: Test resizing image attached to an iothread
From: |
Eric Blake |
Subject: |
Re: [PATCH v2] iotests: Test resizing image attached to an iothread |
Date: |
Tue, 9 May 2023 11:21:03 -0500 |
User-agent: |
NeoMutt/20230407 |
On Tue, May 09, 2023 at 03:41:33PM +0200, Kevin Wolf wrote:
> This tests that trying to resize an image with QMP block_resize doesn't
> hang or otherwise fail when the image is attached to a device running in
> an iothread.
>
> This is a regression test for the recent fix that changed
> qmp_block_resize, which is a coroutine based QMP handler, to avoid
> calling no_coroutine_fns directly.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> v2:
> - Not all formats/protocols support resizing, restrict the list
> - Filter _img_info output, it varies between formats
Shoot, I read my email out-of-order today and gave R-b on v1 before
even seeing that you had already posted v2.
These changes make sense, and make the test better.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org