Re: [PATCH 13/17] qapi: Relax doc string @name: description indentation rules

[Markus Armbruster]

Markus Armbruster <armbru@redhat.com> writes:

> Juan Quintela <quintela@redhat.com> writes:

[...]

>>>  docs/devel/qapi-code-gen.rst          | 10 ++--
>>>  scripts/qapi/parser.py                | 73 +++++++--------------------
>>>  tests/qapi-schema/doc-bad-indent.err  |  2 +-
>>>  tests/qapi-schema/doc-bad-indent.json |  3 +-
>>
>> bad order of files
>>
>>>  tests/qapi-schema/doc-good.json       |  3 +-
>>>  tests/qapi-schema/doc-good.out        |  3 +-
>>
>> good order of files
>>
>> Should we tweak orderfiles so it displays first the json, and the err or
>> out files. reviewing json and then output makes things (at least to me)
>> simpler.
>
> I'll look into it.
>
> Thanks!

We used to put the tests/qapi-schema/*json first, and it was annoying
enough for me to change it in commit b1862ee6233.  Any other ideas?


commit b1862ee6233805172bab89a1fc44e929dcdbd9fa
Author: Markus Armbruster <armbru@redhat.com>
Date:   Fri Sep 13 22:13:34 2019 +0200

    scripts/git.orderfile: Match QAPI schema more precisely
    
    Pattern *.json also matches the tests/qapi-schema/*.json.  Separates
    them from the tests/qapi-schema/*.{err,exit,out} in diffs.  I hate
    that.  Change the pattern to match just the "real" QAPI schemata.
    
    Signed-off-by: Markus Armbruster <armbru@redhat.com>
    Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
    Message-Id: <20190913201349.24332-2-armbru@redhat.com>

diff --git a/scripts/git.orderfile b/scripts/git.orderfile
index ac699700b1..e89790941c 100644
--- a/scripts/git.orderfile
+++ b/scripts/git.orderfile
@@ -19,11 +19,11 @@ Makefile*
 *.mak
 
 # qapi schema
-*.json
+qapi/*.json
+qga/*.json
 
 # headers
 *.h
 
 # code
 *.c
-