Re: [PATCH v2 04/20] block: Don't call no_coroutine_fns in qmp_block

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 04/20] block: Don't call no_coroutine_fns in qmp_block_res

From:	Kevin Wolf
Subject:	Re: [PATCH v2 04/20] block: Don't call no_coroutine_fns in qmp_block_resize()
Date:	Fri, 5 May 2023 14:02:59 +0200

Am 04.05.2023 um 13:57 hat Kevin Wolf geschrieben:
> This QMP handler runs in a coroutine, so it must use the corresponding
> no_co_wrappers instead.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

I just noticed that this actually fixes a reported hang in 8.0. So let's
add:

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2185688
Cc: qemu-stable@nongnu.org

Kevin

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 00/20] Graph locking, part 3 (more block drivers), Kevin Wolf, 2023/05/04
- [PATCH v2 01/20] qcow2: Don't call bdrv_getlength() in coroutine_fns, Kevin Wolf, 2023/05/04
- [PATCH v2 02/20] block: Consistently call bdrv_activate() outside coroutine, Kevin Wolf, 2023/05/04
- [PATCH v2 03/20] block: bdrv/blk_co_unref() for calls in coroutine context, Kevin Wolf, 2023/05/04
- [PATCH v2 04/20] block: Don't call no_coroutine_fns in qmp_block_resize(), Kevin Wolf, 2023/05/04
  - Re: [PATCH v2 04/20] block: Don't call no_coroutine_fns in qmp_block_resize(), Kevin Wolf <=
- [PATCH v2 05/20] test-bdrv-drain: Don't modify the graph in coroutines, Kevin Wolf, 2023/05/04
- [PATCH v2 06/20] graph-lock: Add GRAPH_UNLOCKED(_PTR), Kevin Wolf, 2023/05/04
- [PATCH v2 09/20] nbd: Remove nbd_co_flush() wrapper function, Kevin Wolf, 2023/05/04
- [PATCH v2 14/20] block: Mark bdrv_co_get_info() and callers GRAPH_RDLOCK, Kevin Wolf, 2023/05/04
- [PATCH v2 11/20] vhdx: Require GRAPH_RDLOCK for accessing a node's parent list, Kevin Wolf, 2023/05/04
- [PATCH v2 16/20] block: Mark BlockDriver callbacks for amend job GRAPH_RDLOCK, Kevin Wolf, 2023/05/04
- [PATCH v2 15/20] block: Mark bdrv_co_debug_event() GRAPH_RDLOCK, Kevin Wolf, 2023/05/04
- [PATCH v2 07/20] graph-lock: Fix GRAPH_RDLOCK_GUARD*() to be reader lock, Kevin Wolf, 2023/05/04
- [PATCH v2 12/20] mirror: Require GRAPH_RDLOCK for accessing a node's parent list, Kevin Wolf, 2023/05/04
  - Re: [PATCH v2 12/20] mirror: Require GRAPH_RDLOCK for accessing a node's parent list, Eric Blake, 2023/05/04

Prev by Date: Question about graph locking preconditions regarding qemu_in_main_thread()
Next by Date: Re: [PATCH 9/9] qemu-file: Account for rate_limit usage on qemu_fflush()
Previous by thread: [PATCH v2 04/20] block: Don't call no_coroutine_fns in qmp_block_resize()
Next by thread: [PATCH v2 05/20] test-bdrv-drain: Don't modify the graph in coroutines
Index(es):
- Date
- Thread