[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/16] migration: qemu_file_total_transferred() function is monoto
From: |
Juan Quintela |
Subject: |
[PULL 12/16] migration: qemu_file_total_transferred() function is monotonic |
Date: |
Fri, 5 May 2023 02:48:08 +0200 |
So delta_bytes can only be greater or equal to zero. Never negative.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20230504113841.23130-3-quintela@redhat.com>
---
migration/block.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/migration/block.c b/migration/block.c
index 6d532ac7a2..3499f75e37 100644
--- a/migration/block.c
+++ b/migration/block.c
@@ -801,13 +801,7 @@ static int block_save_iterate(QEMUFile *f, void *opaque)
qemu_put_be64(f, BLK_MIG_FLAG_EOS);
delta_bytes = qemu_file_total_transferred(f) - last_bytes;
- if (delta_bytes > 0) {
- return 1;
- } else if (delta_bytes < 0) {
- return -1;
- } else {
- return 0;
- }
+ return (delta_bytes > 0);
}
/* Called with iothread lock taken. */
--
2.40.0
- [PULL 03/16] migration: Document all migration_stats, (continued)
- [PULL 03/16] migration: Document all migration_stats, Juan Quintela, 2023/05/04
- [PULL 02/16] migration/rdma: Don't pass the QIOChannelRDMA as an opaque, Juan Quintela, 2023/05/04
- [PULL 05/16] migration: Rename xbzrle_enabled xbzrle_started, Juan Quintela, 2023/05/04
- [PULL 04/16] migration: Put zero_pages in alphabetical order, Juan Quintela, 2023/05/04
- [PULL 06/16] migration: Make RAM_SAVE_FLAG_HOOK a normal case entry, Juan Quintela, 2023/05/04
- [PULL 07/16] migration/rdma: simplify ram_control_load_hook(), Juan Quintela, 2023/05/04
- [PULL 08/16] migration/rdma: We can calculate the rioc from the QEMUFile, Juan Quintela, 2023/05/04
- [PULL 09/16] migration/rdma: It makes no sense to recive that flag without RDMA, Juan Quintela, 2023/05/04
- [PULL 10/16] migration/rdma: Check for postcopy sooner, Juan Quintela, 2023/05/04
- [PULL 13/16] qemu-file: No need to check for shutdown in qemu_file_rate_limit, Juan Quintela, 2023/05/04
- [PULL 12/16] migration: qemu_file_total_transferred() function is monotonic,
Juan Quintela <=
- [PULL 11/16] migration: max_postcopy_bandwidth is a size parameter, Juan Quintela, 2023/05/04
- [PULL 14/16] qemu-file: remove shutdown member, Juan Quintela, 2023/05/04
- [PULL 15/16] qemu-file: Make total_transferred an uint64_t, Juan Quintela, 2023/05/04
- [PULL 16/16] qemu-file: Make ram_control_save_page() use accessors for rate_limit, Juan Quintela, 2023/05/04
- Re: [PULL 00/16] Migration 20230505 patches, Richard Henderson, 2023/05/05