[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 09/21] hw/xen: do not use aio_set_fd_handler(is_external=true)
From: |
Stefan Hajnoczi |
Subject: |
[PATCH v5 09/21] hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore |
Date: |
Thu, 4 May 2023 15:53:15 -0400 |
There is no need to suspend activity between aio_disable_external() and
aio_enable_external(), which is mainly used for the block layer's drain
operation.
This is part of ongoing work to remove the aio_disable_external() API.
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Paul Durrant <paul@xen.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
hw/i386/kvm/xen_xenstore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/kvm/xen_xenstore.c b/hw/i386/kvm/xen_xenstore.c
index 900679af8a..6e81bc8791 100644
--- a/hw/i386/kvm/xen_xenstore.c
+++ b/hw/i386/kvm/xen_xenstore.c
@@ -133,7 +133,7 @@ static void xen_xenstore_realize(DeviceState *dev, Error
**errp)
error_setg(errp, "Xenstore evtchn port init failed");
return;
}
- aio_set_fd_handler(qemu_get_aio_context(), xen_be_evtchn_fd(s->eh), true,
+ aio_set_fd_handler(qemu_get_aio_context(), xen_be_evtchn_fd(s->eh), false,
xen_xenstore_event, NULL, NULL, NULL, s);
s->impl = xs_impl_create(xen_domid);
--
2.40.1
- [PATCH v5 01/21] block: Fix use after free in blockdev_mark_auto_del(), (continued)
- [PATCH v5 01/21] block: Fix use after free in blockdev_mark_auto_del(), Stefan Hajnoczi, 2023/05/04
- [PATCH v5 02/21] block-backend: split blk_do_set_aio_context(), Stefan Hajnoczi, 2023/05/04
- [PATCH v5 03/21] hw/qdev: introduce qdev_is_realized() helper, Stefan Hajnoczi, 2023/05/04
- [PATCH v5 04/21] virtio-scsi: avoid race between unplug and transport event, Stefan Hajnoczi, 2023/05/04
- [PATCH v5 05/21] virtio-scsi: stop using aio_disable_external() during unplug, Stefan Hajnoczi, 2023/05/04
- [PATCH v5 06/21] util/vhost-user-server: rename refcount to in_flight counter, Stefan Hajnoczi, 2023/05/04
- [PATCH v5 07/21] block/export: wait for vhost-user-blk requests when draining, Stefan Hajnoczi, 2023/05/04
- [PATCH v5 08/21] block/export: stop using is_external in vhost-user-blk server, Stefan Hajnoczi, 2023/05/04
- [PATCH v5 09/21] hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore,
Stefan Hajnoczi <=
- [PATCH v5 10/21] block: add blk_in_drain() API, Stefan Hajnoczi, 2023/05/04
- [PATCH v5 11/21] block: drain from main loop thread in bdrv_co_yield_to_drain(), Stefan Hajnoczi, 2023/05/04
- [PATCH v5 12/21] xen-block: implement BlockDevOps->drained_begin(), Stefan Hajnoczi, 2023/05/04
- [PATCH v5 14/21] block/export: rewrite vduse-blk drain code, Stefan Hajnoczi, 2023/05/04
- [PATCH v5 16/21] block/fuse: do not set is_external=true on FUSE fd, Stefan Hajnoczi, 2023/05/04
- [PATCH v5 15/21] block/export: don't require AioContext lock around blk_exp_ref/unref(), Stefan Hajnoczi, 2023/05/04
- [PATCH v5 13/21] hw/xen: do not set is_external=true on evtchn fds, Stefan Hajnoczi, 2023/05/04