[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/9] qemu-file: remove shutdown member
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH 6/9] qemu-file: remove shutdown member |
|
Date: |
Thu, 4 May 2023 17:52:50 +0100 |
|
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Thu, May 04, 2023 at 01:38:38PM +0200, Juan Quintela wrote:
> The first thing that we do after setting the shutdown value is set the
> error as -EIO if there is not a previous error.
>
> So this value is reduntant. Just remove it and use
s/reduntant/redundant/
> qemu_file_get_error() in the places that it was tested.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> migration/qemu-file.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH 1/9] migration: max_postcopy_bandwidth is a size parameter, (continued)
- [PATCH 2/9] migration: qemu_file_total_transferred() function is monotonic, Juan Quintela, 2023/05/04
- [PATCH 4/9] qemu-file: Make rate_limit_used an uint64_t, Juan Quintela, 2023/05/04
- [PATCH 5/9] qemu-file: No need to check for shutdown in qemu_file_rate_limit, Juan Quintela, 2023/05/04
- [PATCH 6/9] qemu-file: remove shutdown member, Juan Quintela, 2023/05/04
- [PATCH 8/9] qemu-file: Make ram_control_save_page() use accessors for rate_limit, Juan Quintela, 2023/05/04
- [PATCH 7/9] qemu-file: Make total_transferred an uint64_t, Juan Quintela, 2023/05/04
- [PATCH 9/9] qemu-file: Account for rate_limit usage on qemu_fflush(), Juan Quintela, 2023/05/04