[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 9/9] qemu-file: Account for rate_limit usage on qemu_fflush()
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH 9/9] qemu-file: Account for rate_limit usage on qemu_fflush() |
|
Date: |
Thu, 4 May 2023 10:43:35 -0400 |
On Thu, May 04, 2023 at 01:38:41PM +0200, Juan Quintela wrote:
> That is the moment we know we have transferred something.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
There'll be a slight side effect that qemu_file_rate_limit() can be
triggered later than before because data cached in the qemufile won't be
accounted until flushed.
Two limits here:
- IO_BUF_SIZE==32K, the real buffer
- MAX_IOV_SIZE==64 (I think), the async buffer to put guest page ptrs
directly, on x86 it's 64*4K=256K
So the impact should be no more than 288KB on x86. Looks still fine..
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
- Re: [PATCH 5/9] qemu-file: No need to check for shutdown in qemu_file_rate_limit, (continued)
[PATCH 3/9] qemu-file: make qemu_file_[sg]et_rate_limit() use an uint64_t, Juan Quintela, 2023/05/04
Re: [PATCH 0/9] QEMU file cleanups, Peter Xu, 2023/05/04