[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/9] qemu-file: remove shutdown member
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH 6/9] qemu-file: remove shutdown member |
|
Date: |
Thu, 4 May 2023 10:27:37 -0400 |
On Thu, May 04, 2023 at 01:38:38PM +0200, Juan Quintela wrote:
> The first thing that we do after setting the shutdown value is set the
> error as -EIO if there is not a previous error.
>
> So this value is reduntant. Just remove it and use
> qemu_file_get_error() in the places that it was tested.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
Nit: I'd squash this with previous.
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
- [PATCH 1/9] migration: max_postcopy_bandwidth is a size parameter, (continued)
- [PATCH 1/9] migration: max_postcopy_bandwidth is a size parameter, Juan Quintela, 2023/05/04
- [PATCH 2/9] migration: qemu_file_total_transferred() function is monotonic, Juan Quintela, 2023/05/04
- [PATCH 4/9] qemu-file: Make rate_limit_used an uint64_t, Juan Quintela, 2023/05/04
- [PATCH 5/9] qemu-file: No need to check for shutdown in qemu_file_rate_limit, Juan Quintela, 2023/05/04
- [PATCH 6/9] qemu-file: remove shutdown member, Juan Quintela, 2023/05/04
- [PATCH 8/9] qemu-file: Make ram_control_save_page() use accessors for rate_limit, Juan Quintela, 2023/05/04
- [PATCH 7/9] qemu-file: Make total_transferred an uint64_t, Juan Quintela, 2023/05/04
- [PATCH 9/9] qemu-file: Account for rate_limit usage on qemu_fflush(), Juan Quintela, 2023/05/04