Re: [PATCH 15/20] block: Mark bdrv_co_debug_event() GRAPH_RDLOCK

[Kevin Wolf]

Am 25.04.2023 um 23:14 hat Eric Blake geschrieben:
> On Tue, Apr 25, 2023 at 07:31:53PM +0200, Kevin Wolf wrote:
> > From: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> > 
> > This adds GRAPH_RDLOCK annotations to declare that callers of
> > bdrv_co_debug_event() need to hold a reader lock for the graph.
> > 
> > Unfortunately we cannot use a co_wrapper_bdrv_rdlock, because the
> > function is called by mixed functions that run both in coroutine and
> > non-coroutine context (for example blkdebug_open).
> 
> Is this statement still true after 8/20?

You're right, 8/20 is newer than this commit message and actually made
the example wrong. The problem still exists, though. I'll point to the
qcow2 cluster/refcount functions instead, which are still mixed.

Kevin