qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v10 00/12] parallels: Refactor the code of images checks and


From: Denis V. Lunev
Subject: Re: [PATCH v10 00/12] parallels: Refactor the code of images checks and fix a bug
Date: Mon, 13 Mar 2023 12:34:22 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1

On 3/7/23 13:20, Hanna Czenczek wrote:
On 03.02.23 10:18, Alexander Ivanov wrote:
Fix image inflation when offset in BAT is out of image.

Replace whole BAT syncing by flushing only dirty blocks.

Move all the checks outside the main check function in
separate functions

Use WITH_QEMU_LOCK_GUARD for simplier code.

Fix incorrect condition in out-of-image check.

Apart from my comments (and I think regardless of what happens for patch 1), looks good to me!  Some patches will need to be rebased on the GRAPH_RDLOCK changes, but that looks straightforward.

Hanna

I think that I should pass the process of learning how to send
pull request and make it as soon as possible in order to
learn.

We are really good enough.

Den



reply via email to

[Prev in Thread] Current Thread [Next in Thread]