[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pflash: Fix blk_pread_nonzeroes()
|
From: |
Maciej S. Szmigiero |
|
Subject: |
Re: [PATCH] pflash: Fix blk_pread_nonzeroes() |
|
Date: |
Tue, 7 Mar 2023 16:52:43 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 |
On 7.03.2023 15:02, Kevin Wolf wrote:
Commit a4b15a8b introduced a new function blk_pread_nonzeroes(). Instead
of reading directly from the root node of the BlockBackend, it reads
from its 'file' child node. This can happen to mostly work for raw
images (as long as the 'raw' format driver is in use, but not actually
doing anything), but it breaks everything else.
Fix it to read from the root node instead.
Thanks for preparing the patch.
It seems to work fine, so:
Tested-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
Fixes: a4b15a8b9ef25b44fa92a4825312622600c1f37c
I think this should be:
Fixes: a4b15a8b9e ("pflash: Only read non-zero parts of backend image")
Reported-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
Thanks,
Maciej