[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] configure: Disable thread-safety warnings on macOS

From: Peter Maydell
Subject: Re: [PATCH] configure: Disable thread-safety warnings on macOS
Date: Sat, 4 Mar 2023 15:42:05 +0000

On Wed, 1 Mar 2023 at 13:33, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 01.03.2023 um 12:34 hat Thomas Huth geschrieben:
> > The enablement of -Wthread-safety broke compilation on macOS (if
> > -Werror is enabled, like in our CI). Disable it there by default
> > until the problems are resolved.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> This is simpler than what I attempted (test compiling something using
> the same TSA features as the failing code), but didn't actually work.
> Since I don't have access to macOS, it's hard for me to improve the
> configure test. So I'm fine with just doing this instead.
> Acked-by: Kevin Wolf <kwolf@redhat.com>

I've applied this to master because it fixes the CI job, but
we should probably look more closely at what's going on,
because it seems plausible to me that it's something that we could
hit on Linux too with either a newer or older version of clang.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]