[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/6] block: convert blk_exp_close_all_type() to AIO_WAIT_WHIL
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH 2/6] block: convert blk_exp_close_all_type() to AIO_WAIT_WHILE_UNLOCKED() |
|
Date: |
Thu, 2 Mar 2023 08:08:10 -0500 |
On Thu, Mar 02, 2023 at 11:36:03AM +0100, Philippe Mathieu-Daudé wrote:
> On 1/3/23 21:57, Stefan Hajnoczi wrote:
> > There is no change in behavior. Switch to AIO_WAIT_WHILE_UNLOCKED()
> > instead of AIO_WAIT_WHILE() to document that this code has already been
> > audited and converted. The AioContext argument is already NULL so
> > aio_context_release() is never called anyway.
>
> Shouldn't we assert(ctx && unlock) in AIO_WAIT_WHILE_INTERNAL() then?
Can you show where you'd add that assertion? It's not clear to me what
the purpose is.
Stefan
signature.asc
Description: PGP signature
[PATCH 1/6] block: don't acquire AioContext lock in bdrv_drain_all(), Stefan Hajnoczi, 2023/03/01
- Re: [PATCH 1/6] block: don't acquire AioContext lock in bdrv_drain_all(), Kevin Wolf, 2023/03/07
- Re: [PATCH 1/6] block: don't acquire AioContext lock in bdrv_drain_all(), Stefan Hajnoczi, 2023/03/07
- Re: [PATCH 1/6] block: don't acquire AioContext lock in bdrv_drain_all(), Kevin Wolf, 2023/03/08
- Re: [PATCH 1/6] block: don't acquire AioContext lock in bdrv_drain_all(), Stefan Hajnoczi, 2023/03/08
- Re: [PATCH 1/6] block: don't acquire AioContext lock in bdrv_drain_all(), Kevin Wolf, 2023/03/08
- Re: [PATCH 1/6] block: don't acquire AioContext lock in bdrv_drain_all(), Stefan Hajnoczi, 2023/03/09