Re: [PATCH 0/1] hw/ide: share bmdma read and write functions

[John Snow]

On Fri, Jan 13, 2023 at 9:10 AM Liav Albani <liavalb@gmail.com> wrote:
>
>
> On 1/11/23 01:07, Bernhard Beschow wrote:
>
> Am 9. Januar 2023 19:24:16 UTC schrieb John Snow <jsnow@redhat.com>:
>
> On Tue, Sep 6, 2022 at 10:27 AM Bernhard Beschow <shentey@gmail.com> wrote:
>
> Am 19. Februar 2022 08:08:17 UTC schrieb Liav Albani <liavalb@gmail.com>:
>
> This is a preparation before I send v3 of ich6-ide controller emulation patch.
> I figured that it's more trivial to split the changes this way, by extracting
> the bmdma functions from via.c and piix.c and sharing them together. Then,
> I could easily put these into use when I send v3 of the ich6-ide patch by just
> using the already separated functions. This was suggested by BALATON Zoltan 
> when
> he submitted a code review on my ich6-ide controller emulation patch.
>
> Ping. Any news?
>
> *cough*.
>
> Has this been folded into subsequent series, or does this still need 
> attention?
>
> Both piix and via still have their own bmdma implementations. This patch 
> might be worth having.
>
> Best regards,
> Bernhard
>
> I see. Since you are still interested, I will try to see what was the outcome 
> of that patch as I really don't remember if it passed the CI tests, etc. If 
> applicable, I will send this as v2, or if it's already approved, then I guess 
> we could just let it be merged to the tree?
>

I was just going to run some smoke tests on it and as long as it
didn't hurt anything, I'd wave it in. If you want it alongside other
patches that I also should stage, you can bundle them if you'd like.
Just let me know what you plan on doing.

--js