qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-7.2 3/5] block/mirror: Fix NULL s->job in active writes


From: Hanna Reitz
Subject: Re: [PATCH for-7.2 3/5] block/mirror: Fix NULL s->job in active writes
Date: Thu, 10 Nov 2022 13:40:33 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 10.11.22 13:10, Kevin Wolf wrote:
Am 09.11.2022 um 17:54 hat Hanna Reitz geschrieben:
There is a small gap in mirror_start_job() before putting the mirror
filter node into the block graph (bdrv_append() call) and the actual job
being created.  Before the job is created, MirrorBDSOpaque.job is NULL.

It is possible that requests come in when bdrv_drained_end() is called,
and those requests would see MirrorBDSOpaque.job == NULL.  Have our
filter node handle that case gracefully.

Signed-off-by: Hanna Reitz <hreitz@redhat.com>
This can only happen because bdrv_drained_end() polls, right? So after
changing that it won't be necessary any more, but this series is for 7.2
and the drain one isn't, so this is the right thing to do for now.

I was wondering the same, but I haven’t tested it yet.

Hanna




reply via email to

[Prev in Thread] Current Thread [Next in Thread]