qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-7.2 v2 2/6] hw/nvme: fix cancellation of format operation


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH for-7.2 v2 2/6] hw/nvme: fix cancellation of format operations
Date: Thu, 10 Nov 2022 10:53:47 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1

On 10/11/22 08:05, Klaus Jensen wrote:
From: Klaus Jensen <k.jensen@samsung.com>

Cancelling a format operation neglects to set iocb->ret as well as
clearing the iocb->aiocb after cancelling the underlying aiocb.

Fix this.

Fixes: 3bcf26d3d619 ("hw/nvme: reimplement format nvm to allow cancellation")
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
  hw/nvme/ctrl.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 918af03d32be..819c02067191 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -5762,8 +5762,11 @@ static void nvme_format_cancel(BlockAIOCB *aiocb)
  {
      NvmeFormatAIOCB *iocb = container_of(aiocb, NvmeFormatAIOCB, common);
+ iocb->ret = -ECANCELED;
+
      if (iocb->aiocb) {
          blk_aio_cancel_async(iocb->aiocb);
+        iocb->aiocb = NULL;
      }
  }

What about nvme_flush_cancel()?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]