[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 06/17] vfio/migration: Fix NULL pointer dereference bug
From: |
Avihai Horon |
Subject: |
[PATCH v3 06/17] vfio/migration: Fix NULL pointer dereference bug |
Date: |
Thu, 3 Nov 2022 18:16:09 +0200 |
As part of its error flow, vfio_vmstate_change() accesses
MigrationState->to_dst_file without any checks. This can cause a NULL
pointer dereference if the error flow is taken and
MigrationState->to_dst_file is not set.
For example, this can happen if VM is started or stopped not during
migration and vfio_vmstate_change() error flow is taken, as
MigrationState->to_dst_file is not set at that time.
Fix it by checking that MigrationState->to_dst_file is set before using
it.
Fixes: 02a7e71b1e5b ("vfio: Add VM state change handler to know state of VM")
Signed-off-by: Avihai Horon <avihaih@nvidia.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
---
hw/vfio/migration.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
index 8ae1bd31a8..f5e72c7ac1 100644
--- a/hw/vfio/migration.c
+++ b/hw/vfio/migration.c
@@ -740,7 +740,9 @@ static void vfio_vmstate_change(void *opaque, bool running,
RunState state)
*/
error_report("%s: Failed to set device state 0x%x", vbasedev->name,
(migration->device_state & mask) | value);
- qemu_file_set_error(migrate_get_current()->to_dst_file, ret);
+ if (migrate_get_current()->to_dst_file) {
+ qemu_file_set_error(migrate_get_current()->to_dst_file, ret);
+ }
}
vbasedev->migration->vm_running = running;
trace_vfio_vmstate_change(vbasedev->name, running, RunState_str(state),
--
2.21.3
- Re: [PATCH v3 14/17] vfio/migration: Reset device if setting recover state fails, (continued)
- [PATCH v3 04/17] migration: Simplify migration_iteration_run(), Avihai Horon, 2022/11/03
- [PATCH v3 05/17] vfio/migration: Fix wrong enum usage, Avihai Horon, 2022/11/03
- [PATCH v3 10/17] vfio/migration: Move migration v1 logic to vfio_migration_init(), Avihai Horon, 2022/11/03
- [PATCH v3 06/17] vfio/migration: Fix NULL pointer dereference bug,
Avihai Horon <=
- [PATCH v3 15/17] vfio: Alphabetize migration section of VFIO trace-events file, Avihai Horon, 2022/11/03
- [PATCH v3 16/17] docs/devel: Align vfio-migration docs to VFIO migration v2, Avihai Horon, 2022/11/03
- [PATCH v3 02/17] migration: No save_live_pending() method uses the QEMUFile parameter, Avihai Horon, 2022/11/03
- [PATCH v3 09/17] vfio/common: Change vfio_devices_all_running_and_saving() logic to equivalent one, Avihai Horon, 2022/11/03
- [PATCH v3 17/17] vfio/migration: Query device data size in vfio_save_pending(), Avihai Horon, 2022/11/03
- [PATCH v3 03/17] migration: Block migration comment or code is wrong, Avihai Horon, 2022/11/03