[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHv2] block: use the request length for iov alignment
From: |
Kevin Wolf |
Subject: |
Re: [PATCHv2] block: use the request length for iov alignment |
Date: |
Thu, 29 Sep 2022 19:59:50 +0200 |
Am 29.09.2022 um 18:09 hat Keith Busch geschrieben:
> On Fri, Sep 23, 2022 at 08:34:51AM -0700, Keith Busch wrote:
> >
> > An iov length needs to be aligned to the logical block size, which may
> > be larger than the memory alignment. And since this is only used with
> > file-posix backing storage, move the alignment function to there, where
> > the value of the request_alignment is known to be the file's logical
> > block size.
>
> Any objections to this version? This is fixing real bug reports that
> may become more frequent without this patch.
I think it is okay. Splitting it in two patches would have been nicer
(one for moving code, one for making the change), but it's small enough
that I can ignore that. I'll probably merge it tomorrow.
Kevin