[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 9/9] scripts/qapi: add required system includes to visitor
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 9/9] scripts/qapi: add required system includes to visitor |
Date: |
Thu, 23 Jun 2022 15:43:20 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
marcandre.lureau@redhat.com writes:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The generated visitor code includes abort() & assert(), we shouldn't
> rely on the global "-i" headers to include the necessary system headers.
Suggest ", even though the default qemu/osdep.h always does.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> scripts/qapi/visit.py | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/scripts/qapi/visit.py b/scripts/qapi/visit.py
> index 1ff464c0360f..d686df17f4b6 100644
> --- a/scripts/qapi/visit.py
> +++ b/scripts/qapi/visit.py
> @@ -326,6 +326,8 @@ def __init__(self, prefix: str, include: List[str]):
> def _begin_builtin_module(self) -> None:
> self._genc.preamble_add(mcgen('''
> %(include)s
> +#include <assert.h>
> +#include <stdlib.h>
>
> #include "qapi/error.h"
> #include "qapi/qapi-builtin-visit.h"
> @@ -342,6 +344,8 @@ def _begin_user_module(self, name: str) -> None:
> visit = self._module_basename('qapi-visit', name)
> self._genc.preamble_add(mcgen('''
> %(include)s
> +#include <assert.h>
> +#include <stdlib.h>
>
> #include "qapi/error.h"
> #include "qapi/qmp/qerror.h"
Mildly irritating, because we normally kill such includes as redundant
on sight.
The builtin module (qapi-builtin-visit.c) doesn't actually need these
headers. I guess you include them just in case that changes.
- Re: [PATCH 4/9] error-report: simplify print_loc(), (continued)
- [PATCH 2/9] error-report: misc comment fix, marcandre . lureau, 2022/06/16
- [PATCH 6/9] error-report: add a callback to overwrite error_vprintf, marcandre . lureau, 2022/06/16
- [PATCH 7/9] qapi: move QEMU-specific dispatch code in monitor, marcandre . lureau, 2022/06/16
- [PATCH 5/9] error-report: introduce ErrorReportDetailedFunc, marcandre . lureau, 2022/06/16
- [PATCH 3/9] error-report: introduce "detailed" variable, marcandre . lureau, 2022/06/16
- [PATCH 9/9] scripts/qapi: add required system includes to visitor, marcandre . lureau, 2022/06/16
- Re: [PATCH 9/9] scripts/qapi: add required system includes to visitor,
Markus Armbruster <=
- [PATCH 8/9] scripts/qapi-gen: add -i option, marcandre . lureau, 2022/06/16
- Re: [PATCH 0/9] Preliminary patches for subproject split, Paolo Bonzini, 2022/06/16