[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/25] Migration 20220621 patches
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PULL 00/25] Migration 20220621 patches |
Date: |
Wed, 22 Jun 2022 16:19:17 +0100 |
User-agent: |
Mutt/2.2.5 (2022-05-16) |
* Richard Henderson (richard.henderson@linaro.org) wrote:
> On 6/21/22 17:25, Juan Quintela wrote:
> > The following changes since commit c8b2d413761af732a0798d8df45ce968732083fe:
> >
> > Merge tag 'bsd-user-syscall-2022q2-pull-request' of
> > ssh://github.com/qemu-bsd-user/qemu-bsd-user into staging (2022-06-19
> > 13:56:13 -0700)
> >
> > are available in the Git repository at:
> >
> > https://gitlab.com/juan.quintela/qemu.git
> > tags/migration-20220621-pull-request
> >
> > for you to fetch changes up to 720eceaa316f2a75a7930085bb305850831a065f:
> >
> > migration: remove the QEMUFileOps abstraction (2022-06-21 18:06:55 +0200)
> >
> > ----------------------------------------------------------------
> > Migration Pull request
> >
> > Hi
> >
> > In this today migration PULL request:
> > - dainiel Berrangé qemufileops cleanup
> > - Leonardo Brass cleanups for zero copy
> > - RDMA cleanups (me)
>
> Build failures:
Hmm, I'll fix these up
> https://gitlab.com/qemu-project/qemu/-/jobs/2622407867
> https://gitlab.com/qemu-project/qemu/-/jobs/2622407794
> https://gitlab.com/qemu-project/qemu/-/jobs/2622407791
>
> ../migration/migration.c:166:5: error: 'MIGRATION_CAPABILITY_ZERO_COPY_SEND'
> undeclared here (not in a function); did you mean
> 'MIGRATION_CAPABILITY_ZERO_BLOCKS'?
> 166 | MIGRATION_CAPABILITY_ZERO_COPY_SEND);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../migration/migration.c:145:35: note: in definition of macro
> 'INITIALIZE_MIGRATE_CAPS_SET'
> 145 | .size = sizeof((int []) { __VA_ARGS__ }) / sizeof(int), \
> | ^~~~~~~~~~~
> [1118/1665] Compiling C object libcommon.fa.p/migration_multifd.c.obj
So these are non-Linux's; so I guess that constant is guardded;
>
> https://gitlab.com/qemu-project/qemu/-/jobs/2622407863
> https://gitlab.com/qemu-project/qemu/-/jobs/2622407862
> https://gitlab.com/qemu-project/qemu/-/jobs/2622407860
> https://gitlab.com/qemu-project/qemu/-/jobs/2622407811
>
> ../io/channel-socket.c:589:9: error: implicit declaration of function
> 'g_assert_unreachable' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> g_assert_unreachable();
> ^
Again, non Linux; and should be g_assert_not_reached
I'll fix this up.
Dave
>
> r~
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
- [PULL 16/25] migration: hardcode assumption that QEMUFile is backed with QIOChannel, (continued)
- [PULL 16/25] migration: hardcode assumption that QEMUFile is backed with QIOChannel, Juan Quintela, 2022/06/21
- [PULL 17/25] migration: introduce new constructors for QEMUFile, Juan Quintela, 2022/06/21
- [PULL 20/25] migration: remove the QEMUFileOps 'set_blocking' callback, Juan Quintela, 2022/06/21
- [PULL 19/25] migration: remove the QEMUFileOps 'shut_down' callback, Juan Quintela, 2022/06/21
- [PULL 21/25] migration: remove the QEMUFileOps 'close' callback, Juan Quintela, 2022/06/21
- [PULL 22/25] migration: remove the QEMUFileOps 'get_buffer' callback, Juan Quintela, 2022/06/21
- [PULL 23/25] migration: remove the QEMUFileOps 'writev_buffer' callback, Juan Quintela, 2022/06/21
- [PULL 24/25] migration: remove the QEMUFileOps 'get_return_path' callback, Juan Quintela, 2022/06/21
- [PULL 25/25] migration: remove the QEMUFileOps abstraction, Juan Quintela, 2022/06/21
- Re: [PULL 00/25] Migration 20220621 patches, Richard Henderson, 2022/06/21
- Re: [PULL 00/25] Migration 20220621 patches,
Dr. David Alan Gilbert <=