qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 07/21] migration: rename qemu_update_position to qemu_file


From: Juan Quintela
Subject: Re: [PATCH v2 07/21] migration: rename qemu_update_position to qemu_file_credit_transfer
Date: Mon, 20 Jun 2022 17:14:41 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Daniel P. Berrangé <berrange@redhat.com> wrote:
> The qemu_update_position method name gives the misleading impression
> that it is changing the current file offset. Most of the files are
> just streams, however, so there's no concept of a file offset in the
> general case.
>
> What this method is actually used for is to report on the number of
> bytes that have been transferred out of band from the main I/O methods.
> This new name better reflects this purpose.
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

I started, but not finished a change to not use qemu_file to limit
transfer, i.e. to not need this code at all.  but it is not finished,
so.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]