[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/5] hw/nvme: do not auto-generate eui64
From: |
Christoph Hellwig |
Subject: |
Re: [PATCH v2 2/5] hw/nvme: do not auto-generate eui64 |
Date: |
Fri, 29 Apr 2022 17:17:15 +0200 |
User-agent: |
Mutt/1.5.17 (2007-11-01) |
On Fri, Apr 29, 2022 at 10:33:33AM +0200, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> We cannot provide auto-generated unique or persistent namespace
> identifiers (EUI64, NGUID, UUID) easily. Since 6.1, namespaces have been
> assigned a generated EUI64 of the form "52:54:00:<namespace counter>".
> This is will be unique within a QEMU instance, but not globally.
>
> Revert that this is assigned automatically and immediately deprecate the
> compatibility parameter. Users can opt-in to this with the
> `eui64-default=on` device parameter or set it explicitly with
> `eui64=UINT64`.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
- [PATCH v2 0/5] hw/nvme: fix namespace identifiers, Klaus Jensen, 2022/04/29
- [PATCH v2 1/5] hw/nvme: enforce common serial per subsystem, Klaus Jensen, 2022/04/29
- [PATCH v2 2/5] hw/nvme: do not auto-generate eui64, Klaus Jensen, 2022/04/29
- Re: [PATCH v2 2/5] hw/nvme: do not auto-generate eui64,
Christoph Hellwig <=
- [PATCH v2 3/5] hw/nvme: do not auto-generate uuid, Klaus Jensen, 2022/04/29
- [PATCH v2 4/5] hw/nvme: do not report null uuid, Klaus Jensen, 2022/04/29
- [PATCH v2 5/5] hw/nvme: bump firmware revision, Klaus Jensen, 2022/04/29