[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 5/7] multifd: multifd_send_sync_main now returns negative
|
From: |
Leonardo Bras Soares Passos |
|
Subject: |
Re: [PATCH v9 5/7] multifd: multifd_send_sync_main now returns negative on error |
|
Date: |
Tue, 26 Apr 2022 13:08:26 -0300 |
On Tue, Apr 26, 2022 at 9:59 AM Peter Xu <peterx@redhat.com> wrote:
>
> On Mon, Apr 25, 2022 at 06:50:54PM -0300, Leonardo Bras wrote:
> > Even though multifd_send_sync_main() currently emits error_reports, it's
> > callers don't really check it before continuing.
> >
> > Change multifd_send_sync_main() to return -1 on error and 0 on success.
> > Also change all it's callers to make use of this change and possibly fail
> > earlier.
> >
> > (This change is important to next patch on multifd zero copy
> > implementation, to make it sure an error in zero-copy flush does not go
> > unnoticed.
> >
> > Signed-off-by: Leonardo Bras <leobras@redhat.com>
>
> Reviewed-by: Peter Xu <peterx@redhat.com>
>
> --
> Peter Xu
>
Thanks Peter!
Best regards,
Leo
- [PATCH v9 0/7] MSG_ZEROCOPY + multifd, Leonardo Bras, 2022/04/25
- [PATCH v9 3/7] migration: Add zero-copy-send parameter for QMP/HMP for Linux, Leonardo Bras, 2022/04/25
- [PATCH v9 1/7] QIOChannel: Add flags on io_writev and introduce io_flush callback, Leonardo Bras, 2022/04/25
- [PATCH v9 5/7] multifd: multifd_send_sync_main now returns negative on error, Leonardo Bras, 2022/04/25
- [PATCH v9 4/7] migration: Add migrate_use_tls() helper, Leonardo Bras, 2022/04/25
- [PATCH v9 2/7] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX, Leonardo Bras, 2022/04/25
- [PATCH v9 6/7] multifd: Send header packet without flags if zero-copy-send is enabled, Leonardo Bras, 2022/04/25
- [PATCH v9 7/7] multifd: Implement zero copy write in multifd migration (multifd-zero-copy), Leonardo Bras, 2022/04/25