Re: [PATCH v4 2/3] util/main-loop: Introduce the main loop into QOM

[Nicolas Saenz Julienne]

On Fri, 2022-04-22 at 13:40 +0200, Nicolas Saenz Julienne wrote:
> > > +##
> > > +{ 'struct': 'EventLoopBaseProperties',
> > > +  'data': { '*aio-max-batch': 'int' } }
> > > +
> > >  ##
> > >  # @IothreadProperties:
> > >  #
> > > @@ -516,17 +527,26 @@
> > >  #               algorithm detects it is spending too long polling without
> > >  #               encountering events. 0 selects a default behaviour 
> > > (default: 0)
> > >  #
> > > -# @aio-max-batch: maximum number of requests in a batch for the AIO 
> > > engine,
> > > -#                 0 means that the engine will use its default
> > > -#                 (default:0, since 6.1)
> > > +# The @aio-max-batch option is available since 6.1.
> > 
> > This separates the member's "since" information from its defintion.
> > Can't be helped, because its defined in the base type, but the since
> > only applies here.  Okay.
> 
> IIUC my compromise of having the 'since version' annotated on each externally
> visible type is good, right? No need to add the info in
> EventLoopBaseProperties.

OK, nevermind this reply. I misunderstood you. I'll:
 - Add a "since 7.1" in EventLoopBaseProperties.
 - Add a special comment in IothreadProperties mentioning aio-max-batch is
   available since 6.1.
 - Remove version info from MainLoopProperties.

Thanks!

-- 
Nicolás Sáenz