[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/nvme: fix narrowing conversion
From: |
Klaus Jensen |
Subject: |
Re: [PATCH] hw/nvme: fix narrowing conversion |
Date: |
Tue, 12 Apr 2022 22:36:37 +0200 |
On Apr 12 11:59, Dmitry Tikhov wrote:
> Since nlbas is of type int, it does not work with large namespace size
> values, e.g., 9 TB size of file backing namespace and 8 byte metadata
> with 4096 bytes lbasz gives negative nlbas value, which is later
> promoted to negative int64_t type value and results in negative
> ns->moff which breaks namespace
>
> Signed-off-by: Dmitry Tikhov <ddtikhov@gmail.com>
> ---
> hw/nvme/ns.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/nvme/ns.c b/hw/nvme/ns.c
> index 324f53ea0c..af6504fad2 100644
> --- a/hw/nvme/ns.c
> +++ b/hw/nvme/ns.c
> @@ -29,7 +29,8 @@ void nvme_ns_init_format(NvmeNamespace *ns)
> {
> NvmeIdNs *id_ns = &ns->id_ns;
> BlockDriverInfo bdi;
> - int npdg, nlbas, ret;
> + int npdg, ret;
> + int64_t nlbas;
>
> ns->lbaf = id_ns->lbaf[NVME_ID_NS_FLBAS_INDEX(id_ns->flbas)];
> ns->lbasz = 1 << ns->lbaf.ds;
> @@ -42,7 +43,7 @@ void nvme_ns_init_format(NvmeNamespace *ns)
> id_ns->ncap = id_ns->nsze;
> id_ns->nuse = id_ns->ncap;
>
> - ns->moff = (int64_t)nlbas << ns->lbaf.ds;
> + ns->moff = nlbas << ns->lbaf.ds;
>
> npdg = ns->blkconf.discard_granularity / ns->lbasz;
>
> --
> 2.35.1
>
Thanks Dmitry. Looks reasonable,
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
signature.asc
Description: PGP signature