[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 17/18] iotests: remove qemu_img_pipe_and_status()
From: |
Eric Blake |
Subject: |
Re: [PATCH v5 17/18] iotests: remove qemu_img_pipe_and_status() |
Date: |
Mon, 21 Mar 2022 16:31:51 -0500 |
User-agent: |
NeoMutt/20211029-454-6adf99 |
On Mon, Mar 21, 2022 at 04:16:17PM -0400, John Snow wrote:
> With the exceptional 'create' calls removed in the prior commit, change
> qemu_img_log() and img_info_log() to call qemu_img() directly
> instead.
>
> For now, allow these calls to qemu-img to return non-zero on the basis
> that any unusual output will be logged anyway. The very next commit
> begins to enforce a successful exit code by default even for the logged
> functions.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/qemu-iotests/iotests.py | 26 +++++++-------------------
> 1 file changed, 7 insertions(+), 19 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH v5 08/18] iotests: add qemu_img_info(), (continued)
- [PATCH v5 08/18] iotests: add qemu_img_info(), John Snow, 2022/03/21
- [PATCH v5 12/18] iotests: replace unchecked calls to qemu_img_pipe(), John Snow, 2022/03/21
- [PATCH v5 13/18] iotests/149: Remove qemu_img_pipe() call, John Snow, 2022/03/21
- [PATCH v5 10/18] iotests: add qemu_img_map() function, John Snow, 2022/03/21
- [PATCH v5 15/18] iotests: use qemu_img() in has_working_luks(), John Snow, 2022/03/21
- [PATCH v5 16/18] iotests: replace qemu_img_log('create', ...) calls, John Snow, 2022/03/21
- [PATCH v5 14/18] iotests: remove remaining calls to qemu_img_pipe(), John Snow, 2022/03/21
- [PATCH v5 18/18] iotests: make qemu_img_log and img_info_log raise on error, John Snow, 2022/03/21
- [PATCH v5 17/18] iotests: remove qemu_img_pipe_and_status(), John Snow, 2022/03/21
- Re: [PATCH v5 17/18] iotests: remove qemu_img_pipe_and_status(),
Eric Blake <=
- Re: [PATCH v5 00/18] iotests: add enhanced debugging info to qemu-img failures, Hanna Reitz, 2022/03/22