Re: [PULL for-7.0 1/2] aio-posix: fix build failure io_uring 2.2

[Stefan Hajnoczi]

On Thu, Mar 17, 2022 at 05:14:20PM +0000, Daniel P. Berrangé wrote:
> On Thu, Mar 17, 2022 at 04:57:42PM +0000, Stefan Hajnoczi wrote:
> > From: Haiyue Wang <haiyue.wang@intel.com>
> > 
> > The io_uring fixed "Don't truncate addr fields to 32-bit on 32-bit":
> > https://git.kernel.dk/cgit/liburing/commit/?id=d84c29b19ed0b130000619cff40141bb1fc3615b
> 
> Ewww, that changes the public ABI of the library on 32-bit
> platforms, but failed to bump the soname version, except....
> 
> ...investigating this I noticed a further change that happend
> a few weeks earlier in liburing that actually dropped the
> version from the soname entirely making it an unversioned
> library.
> 
> This is the current shipping 2.1 version:
> 
> $ eu-readelf -a liburing.so.2.0.0  | grep SONAME
>   SONAME            Library soname: [liburing.so.2]
> 
> and in git master:
> 
> $ eu-readelf -a src/liburing.so.2.2 | grep SONA
>   SONAME            Library soname: [liburing.so]
> 
> Surely that's a mistake.
> 
> After the ABI incompatibility above, I would have expected
> it to bump to liburing.so.3 

Thanks, I have sent a liburing patch to fix the soname.

Stefan

signature.asc
Description: PGP signature