[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 02/15] iotests/163: Fix broken qemu-io invocation
From: |
John Snow |
Subject: |
[PATCH 02/15] iotests/163: Fix broken qemu-io invocation |
Date: |
Fri, 18 Mar 2022 16:36:42 -0400 |
The 'read' commands to qemu-io were malformed, and this invocation only
worked by coincidence because the error messages were identical. Oops.
There's no point in checking the patterning of the reference image, so
just check the empty image by itself instead.
(Note: as of this commit, nothing actually enforces that this command
completes successfully, but a forthcoming commit in this series will
enforce that qemu_io() must have a zero status code.)
Signed-off-by: John Snow <jsnow@redhat.com>
---
tests/qemu-iotests/163 | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/163 b/tests/qemu-iotests/163
index e4cd4b230f..c94ad16f4a 100755
--- a/tests/qemu-iotests/163
+++ b/tests/qemu-iotests/163
@@ -113,10 +113,7 @@ class ShrinkBaseClass(iotests.QMPTestCase):
qemu_img('resize', '-f', iotests.imgfmt, '--shrink', test_img,
self.shrink_size)
- self.assertEqual(
- qemu_io('-c', 'read -P 0x00 %s'%self.shrink_size, test_img),
- qemu_io('-c', 'read -P 0x00 %s'%self.shrink_size, check_img),
- "Verifying image content")
+ qemu_io('-c', f"read -P 0x00 0 {self.shrink_size}", test_img)
self.image_verify()
--
2.34.1
[PATCH 05/15] iotests: create generic qemu_tool() function, John Snow, 2022/03/18
[PATCH 02/15] iotests/163: Fix broken qemu-io invocation,
John Snow <=
[PATCH 12/15] iotests/migration-permissions: use assertRaises() for qemu_io() negative test, John Snow, 2022/03/18
[PATCH 06/15] iotests: rebase qemu_io() on top of qemu_tool(), John Snow, 2022/03/18