Re: [PATCH v4] tests: Do not treat the iotests as separate meson test target anymore

[Thomas Huth]

On 18/03/2022 18.04, Hanna Reitz wrote:
> On 10.03.22 08:50, Thomas Huth wrote:
> > If there is a failing iotest, the output is currently not logged to
> > the console anymore. To get this working again, we need to run the
> > meson test runner with "--print-errorlogs" (and without "--verbose"
> > due to a current meson bug that will be fixed here:
> > https://github.com/mesonbuild/meson/commit/c3f145ca2b9f5.patch ).
> > We could update the "meson test" call in tests/Makefile.include,
> > but actually it's nicer and easier if we simply do not treat the
> > iotests as separate test target anymore and integrate them along
> > with the other test suites. This has the disadvantage of not getting
> > the detailed progress indication there anymore, but since that was
> > only working right in single-threaded "make -j1" mode anyway, it's
> > not a huge loss right now.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >   v4: updated commit description
> >
> >   meson.build            | 6 +++---
> >   scripts/mtest2make.py  | 4 ----
> >   tests/Makefile.include | 9 +--------
> >   3 files changed, 4 insertions(+), 15 deletions(-)
>
> I can’t really say I understand what’s going on in this patch and around it, 
> but I can confirm that it before this patch, fail diffs aren’t printed; but 
> afterwards, they are

It's a bug in Meson. It will be fixed in 0.61.3 and later (so this patch 
won't be needed there anymore), but the update to meson 0.61.3 caused other 
problems so we also can't do that right now... so I'm not sure whether we 
now want to have this patch here included, wait for a better version of 
meson, or even rather want to revert the TAP support / meson integration 
again for 7.0 ... ?

 Thomas