qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 13/14] iotests: make qemu_img_log() check log level


From: Hanna Reitz
Subject: Re: [PATCH 13/14] iotests: make qemu_img_log() check log level
Date: Thu, 17 Mar 2022 16:34:29 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 09.03.22 04:54, John Snow wrote:
Improve qemu_img_log() to actually check if logging is turned on. If it
isn't, revert to the behavior of qemu_img(). This is done so that there
really is no way to avoid scrutinizing qemu-ing subprocess calls by
accident.

Signed-off-by: John Snow <jsnow@redhat.com>
---
  tests/qemu-iotests/iotests.py | 19 ++++++++++++++++++-
  1 file changed, 18 insertions(+), 1 deletion(-)

Looks OK to me, so

Reviewed-by: Hanna Reitz <hreitz@redhat.com>

But I’d really just prefer `qemu_img_log()` to check the exit status all the time.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]