Re: [PATCH v3 4/5] iotests: make qemu_img raise on non-zero rc by default

[Hanna Reitz]

On 17.03.22 11:25, Hanna Reitz wrote:
> On 08.03.22 02:57, John Snow wrote:
> > re-write qemu_img() as a function that will by default raise a
> > VerboseProcessException (extended from CalledProcessException) on
> > non-zero return codes. This will produce a stack trace that will show
> > the command line arguments and return code from the failed process run.
>
> Why not qemu_img_pipe_and_status() as the central function where all 
> qemu-img calls go through?

OK, I see that your follow-up series effectively does this.  Still 
wondering why this patch here doesn’t touch qemu_img_pipe_and_status() 
instead.

> It seems like this makes qemu_img() a second version of 
> qemu_img_pipe_and_status(), which is a bit weird.
>
> (Or perhaps it should actually be qemu_tool_pipe_and_status() that 
> receives this treatment, with qemu-io functions just passing 
> check=False by default.)

(And perhaps this, but I guess qemu-io is the only other real user of 
qemu_tool_pipe_and_status(), so if it doesn’t care, then there’s no real 
reason to change that function.)

Hanna