[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/27] Replace GCC_FMT_ATTR with G_GNUC_PRINTF
|
From: |
Richard W.M. Jones |
|
Subject: |
Re: [PATCH 07/27] Replace GCC_FMT_ATTR with G_GNUC_PRINTF |
|
Date: |
Wed, 16 Mar 2022 12:07:53 +0000 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Mar 16, 2022 at 01:52:48PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> One less qemu-specific macro. It also helps to make some headers/units
> only depend on glib, and thus moved in standalone projects eventually.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
I checked the replacements and couldn't spot any differences (I assume
you used a 'perl -pi.bak -e s///' or similar rather than doing it by
hand?). Also I checked the macro definitions in
include/qemu/compiler.h vs /usr/include/glib-2.0/glib/gmacros.h and
they're pretty much identical. I even learned about gnu_printf. So:
Reviewed-by: Richard W.M. Jones <rjones@redhat.com>
Shouldn't there be a hunk which removes the definition of GCC_FMT_ATTR
from include/qemu/compiler.h? Maybe that's in another place in the
patch series.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top