[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 29/35] qemu_co_rwlock_rdlock
From: |
Paolo Bonzini |
Subject: |
[PATCH 29/35] qemu_co_rwlock_rdlock |
Date: |
Thu, 10 Mar 2022 13:44:07 +0100 |
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
util/qemu-coroutine-lock.c | 40 +++++++++++++++++++++++++++++---------
1 file changed, 31 insertions(+), 9 deletions(-)
diff --git a/util/qemu-coroutine-lock.c b/util/qemu-coroutine-lock.c
index 3b50e1dd5b..e7eb446566 100644
--- a/util/qemu-coroutine-lock.c
+++ b/util/qemu-coroutine-lock.c
@@ -402,32 +402,54 @@ static CoroutineAction
qemu_co_rwlock_maybe_wake_one(CoRwlock *lock)
return COROUTINE_CONTINUE;
}
-#if 0
-void qemu_co_rwlock_rdlock(CoRwlock *lock)
+CO_DECLARE_FRAME(qemu_co_rwlock_rdlock, CoRwlock *lock, Coroutine *self,
CoRwTicket my_ticket);
+static CoroutineAction co__qemu_co_rwlock_rdlock(void *_frame)
{
+ struct FRAME__qemu_co_rwlock_rdlock *_f = _frame;
+ CO_ARG(lock);
Coroutine *self = qemu_coroutine_self();
- qemu_co_mutex_lock(&lock->mutex);
+switch(_f->_step) {
+case 0:
+_f->_step = 1;
+CO_SAVE(self);
+ return qemu_co_mutex_lock(&lock->mutex);
+case 1:
+CO_LOAD(self);
/* For fairness, wait if a writer is in line. */
if (lock->owners == 0 || (lock->owners > 0 &&
QSIMPLEQ_EMPTY(&lock->tickets))) {
lock->owners++;
qemu_co_mutex_unlock(&lock->mutex);
} else {
- CoRwTicket my_ticket = { true, self };
+ _f->my_ticket = (CoRwTicket){ true, self };
- QSIMPLEQ_INSERT_TAIL(&lock->tickets, &my_ticket, next);
+ QSIMPLEQ_INSERT_TAIL(&lock->tickets, &_f->my_ticket, next);
qemu_co_mutex_unlock(&lock->mutex);
- qemu_coroutine_yield();
+
+_f->_step = 2;
+ return qemu_coroutine_yield();
+case 2:
assert(lock->owners >= 1);
/* Possibly wake another reader, which will wake the next in line. */
- qemu_co_mutex_lock(&lock->mutex);
+_f->_step = 3;
+ return qemu_co_mutex_lock(&lock->mutex);
+case 3:
+CO_LOAD(self);
qemu_co_rwlock_maybe_wake_one(lock);
}
-
- self->locks_held++;
}
+ self->locks_held++;
+return stack_free(&_f->common);
+}
+
+CoroutineAction qemu_co_rwlock_rdlock(CoRwlock *lock)
+{
+ return CO_INIT_FRAME(qemu_co_rwlock_rdlock, lock);
+}
+
+#if 0
void qemu_co_rwlock_unlock(CoRwlock *lock)
{
Coroutine *self = qemu_coroutine_self();
--
2.35.1
- [PATCH 18/35] /basic/order, (continued)
- [PATCH 18/35] /basic/order, Paolo Bonzini, 2022/03/10
- [PATCH 27/35] /locking/co-mutex/lockable, Paolo Bonzini, 2022/03/10
- [PATCH 23/35] /perf/cost, Paolo Bonzini, 2022/03/10
- [PATCH 12/35] define magic macros for stackless coroutines, Paolo Bonzini, 2022/03/10
- [PATCH 15/35] /basic/self, Paolo Bonzini, 2022/03/10
- [PATCH 19/35] /perf/lifecycle, Paolo Bonzini, 2022/03/10
- [PATCH 22/35] /perf/function-call, Paolo Bonzini, 2022/03/10
- [PATCH 24/35] /basic/no-dangling-access, Paolo Bonzini, 2022/03/10
- [PATCH 25/35] /locking/co-mutex, Paolo Bonzini, 2022/03/10
- [PATCH 28/35] qemu_co_rwlock_maybe_wake_one, Paolo Bonzini, 2022/03/10
- [PATCH 29/35] qemu_co_rwlock_rdlock,
Paolo Bonzini <=
- [PATCH 30/35] qemu_co_rwlock_unlock, Paolo Bonzini, 2022/03/10
- [PATCH 31/35] qemu_co_rwlock_downgrade, Paolo Bonzini, 2022/03/10
- [PATCH 32/35] qemu_co_rwlock_wrlock, Paolo Bonzini, 2022/03/10
- [PATCH 34/35] /locking/co-rwlock/upgrade, Paolo Bonzini, 2022/03/10
- [PATCH 35/35] /locking/co-rwlock/downgrade, Paolo Bonzini, 2022/03/10
- [PATCH 33/35] qemu_co_rwlock_upgrade, Paolo Bonzini, 2022/03/10
- Re: [PATCH experiment 00/35] stackless coroutine backend, Stefan Hajnoczi, 2022/03/10