[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/4] Introduce event-loop-base abstract class
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH v2 2/4] Introduce event-loop-base abstract class |
|
Date: |
Thu, 10 Mar 2022 10:25:19 +0000 |
On Thu, Mar 03, 2022 at 03:58:20PM +0100, Nicolas Saenz Julienne wrote:
> @@ -2935,13 +2947,6 @@ qemu_syms = custom_target('qemu.syms', output:
> 'qemu.syms',
> capture: true,
> command: [undefsym, nm, '@INPUT@'])
>
> -qom_ss = qom_ss.apply(config_host, strict: false)
> -libqom = static_library('qom', qom_ss.sources() + genh,
> - dependencies: [qom_ss.dependencies()],
> - name_suffix: 'fa')
> -
> -qom = declare_dependency(link_whole: libqom)
> -
Why was it necessary to move qom_ss and subdir('hw') up? Can
event_loop_base be defined down here instead?
(The benefit of less code churn is it reduces the risk of patch conflicts.)
signature.asc
Description: PGP signature
[PATCH v2 3/4] util/main-loop: Introduce the main loop into QOM, Nicolas Saenz Julienne, 2022/03/03
[PATCH v2 4/4] util/event-loop-base: Introduce options to set the thread pool size, Nicolas Saenz Julienne, 2022/03/03