Re: [PATCH] hw/block: m25p80: Add support for w25q01jvq

[Michael Walle]

Am 2022-03-04 20:30, schrieb Philippe Mathieu-Daudé:
> On 4/3/22 19:09, Patrick Williams wrote:
> > The w25q01jvq is a 128MB part.  Support is being added to the 
> > kernel[1]
> > and the two have been tested together.
> >
> > 1. 
> > https://lore.kernel.org/lkml/20220222092222.23108-1-potin.lai@quantatw.com/
> >
> > Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
> > Cc: Potin Lai <potin.lai@quantatw.com>
> > ---
> >   hw/block/m25p80.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> > index c6bf3c6bfa..7d3d8b12e0 100644
> > --- a/hw/block/m25p80.c
> > +++ b/hw/block/m25p80.c
> > @@ -340,6 +340,7 @@ static const FlashPartInfo known_devices[] = {
> >       { INFO("w25q80bl",    0xef4014,      0,  64 << 10,  16, ER_4K) 
> > },
> >       { INFO("w25q256",     0xef4019,      0,  64 << 10, 512, ER_4K) 
> > },
> >       { INFO("w25q512jv",   0xef4020,      0,  64 << 10, 1024, ER_4K) 
> > },
> > +    { INFO("w25q01jvq",   0xef4021,      0,  64 << 10, 2048, ER_4K) 
> > },
> >   };
> >     typedef enum {
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

FWIW, the linux spi nor subsystem will rely more and more on the SFDP
for newer flashes. I had a quick look at qemu's source and command
RDSFDP (0x5a) isn't emulated. Might be worth implementing ;)

-michael