Re: [PATCH v2 3/5] iotests: Remove explicit checks for qemu_img() == 0

[Eric Blake]

On Fri, Mar 04, 2022 at 02:47:44PM -0500, John Snow wrote:
> qemu_img() returning zero ought to be the rule, not the
> exception. Remove all explicit checks against the condition in
> preparation for making non-zero returns an Exception.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---

> +++ b/tests/qemu-iotests/310

> @@ -105,8 +105,8 @@ with iotests.FilePath('base.img') as base_img_path, \
>      log('')
>  
>      # Detach backing to check that we can read the data from the top level 
> now
> -    assert qemu_img('rebase', '-u', '-b', '', '-f', iotests.imgfmt,
> -                    top_img_path) == 0
> +    qemu_img('rebase', '-u', '-b', '', '-f', iotests.imgfmt,
> +             top_img_path)

You collapsed other wrapped lines into one where they fit, why not
this one?  But it's not essential.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org