[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/5] block/amend: Keep strong reference to BDS
From: |
Hanna Reitz |
Subject: |
[PATCH 4/5] block/amend: Keep strong reference to BDS |
Date: |
Fri, 4 Mar 2022 16:37:28 +0100 |
Otherwise, the BDS might be freed while the job is running, which would
cause a use-after-free.
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
---
block/amend.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/amend.c b/block/amend.c
index 553890ded9..f696a006e3 100644
--- a/block/amend.c
+++ b/block/amend.c
@@ -69,6 +69,8 @@ static void blockdev_amend_free(Job *job)
if (s->bs->drv->bdrv_amend_clean) {
s->bs->drv->bdrv_amend_clean(s->bs);
}
+
+ bdrv_unref(s->bs);
}
static const JobDriver blockdev_amend_job_driver = {
@@ -129,6 +131,7 @@ void qmp_x_blockdev_amend(const char *job_id,
return;
}
+ bdrv_ref(bs);
s->bs = bs,
s->opts = QAPI_CLONE(BlockdevAmendOptions, options),
s->force = has_force ? force : false;
--
2.34.1
- [PATCH 0/5] block/amend: Fix failures seen in iotest 296, Hanna Reitz, 2022/03/04
- [PATCH 1/5] block/amend: Clean up job on early failure, Hanna Reitz, 2022/03/04
- [PATCH 2/5] block/amend: Always call .bdrv_amend_clean(), Hanna Reitz, 2022/03/04
- [PATCH 3/5] block/crypto: Reset updating_keys on perm failure, Hanna Reitz, 2022/03/04
- [PATCH 5/5] iotests/296: Accept early failure, Hanna Reitz, 2022/03/04
- [PATCH 4/5] block/amend: Keep strong reference to BDS,
Hanna Reitz <=
- Re: [PATCH 0/5] block/amend: Fix failures seen in iotest 296, Kevin Wolf, 2022/03/04