[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] Allow building vhost-user in BSD
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 2/2] Allow building vhost-user in BSD |
Date: |
Wed, 2 Mar 2022 18:26:31 +0000 |
User-agent: |
Mutt/2.1.5 (2021-12-30) |
On Wed, Mar 02, 2022 at 07:05:32PM +0100, Paolo Bonzini wrote:
> On 3/2/22 18:38, Philippe Mathieu-Daudé wrote:
> > On 2/3/22 18:31, Sergio Lopez wrote:
> > > On Wed, Mar 02, 2022 at 06:18:59PM +0100, Philippe Mathieu-Daudé wrote:
> > > > On 2/3/22 18:10, Paolo Bonzini wrote:
> > > > > On 3/2/22 12:36, Sergio Lopez wrote:
> > > > > > With the possibility of using pipefd as a replacement on operating
> > > > > > systems that doesn't support eventfd, vhost-user can also work on
> > > > > > BSD
> > > > > > systems.
> > > > > >
> > > > > > This change allows enabling vhost-user on BSD platforms too and
> > > > > > makes libvhost_user (which still depends on eventfd) a linux-only
> > > > > > feature.
> > > > > >
> > > > > > Signed-off-by: Sergio Lopez <slp@redhat.com>
> > > > >
> > > > > I would just check for !windows.
> > > >
> > > > What about Darwin / Haiku / Illumnos?
> > >
> > > It should work on every system providing pipe() or pipe2(), so I guess
> > > Paolo's right, every platform except Windows. FWIW, I already tested
> > > it with Darwin.
> >
> > Wow, nice.
> >
> > So maybe simply check for pipe/pipe2 rather than !windows?
>
> What you really need is not pipes, but AF_UNIX.
Recent Windows has AF_UNIX so don't check for that ! What you really
need is AF_UNIX and FD passing and pipes and probably more POSIX
only features ...
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 0/2] Enable vhost-user to be used on BSD systems, Sergio Lopez, 2022/03/02
- [PATCH 2/2] Allow building vhost-user in BSD, Sergio Lopez, 2022/03/02
- Re: [PATCH 2/2] Allow building vhost-user in BSD, Paolo Bonzini, 2022/03/02
- Re: [PATCH 2/2] Allow building vhost-user in BSD, Philippe Mathieu-Daudé, 2022/03/02
- Re: [PATCH 2/2] Allow building vhost-user in BSD, Sergio Lopez, 2022/03/02
- Re: [PATCH 2/2] Allow building vhost-user in BSD, Philippe Mathieu-Daudé, 2022/03/02
- Re: [PATCH 2/2] Allow building vhost-user in BSD, Sergio Lopez, 2022/03/02
- Re: [PATCH 2/2] Allow building vhost-user in BSD, Daniel P . Berrangé, 2022/03/02
- Re: [PATCH 2/2] Allow building vhost-user in BSD, Philippe Mathieu-Daudé, 2022/03/02
- Re: [PATCH 2/2] Allow building vhost-user in BSD, Paolo Bonzini, 2022/03/02
- Re: [PATCH 2/2] Allow building vhost-user in BSD,
Daniel P . Berrangé <=
[PATCH 1/2] Allow returning EventNotifier's wfd, Sergio Lopez, 2022/03/02